-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make input.sh compatible with all OSes (re-write input.sh using python) #26
Comments
Dear @ilyasst , |
Dear @ilyasst , For the users who are not Kaggers,
(Kaggle users can download them manually with I will create a pull request for "1. The number of cases" later. |
Dear @ilyasst , Please kindly comfirm it with the default branch. (Version 2.2.5) import covsirphy as cs
# Set the directory to save the datasets
data_loader = cs.DataLoader("input")
# JHU dataset
jhu_data = data_loader.jhu()
print(jhu_data.citation)
jhu_data.cleaned()
# The number of cases in Japan
japan_data = data_loader.japan()
print(japan_data.citation)
jhu_data.replace(japan_data)
ncov_df = jhu_data.cleaned()
# OxCGRT dataset
oxcgrt_data = data_loader.oxcgrt()
print(oxcgrt_data.citation)
oxcgrt_df = oxcgrt_data.cleaned()
jpn_oxcgrt_df = oxcgrt_data.subset(iso3="JPN")
|
I have pulled the code from master and followed the I was also able to use I will submit a PR for this shortly. |
Dear @ilyasst , However, I don't recommend keeping kaggle.json in your working directory for a security reason. It may cause leak of your API keys accidentally. data_loader = DataLoader(directory=None)
jhu_data = data_loader.jhu(local_file="kaggle/input/novel-corona-virus-2019-dataset/covid_19_data.csv")
japan_data = data_loader.japan(local_file="kaggle/input/covid19-dataset-in-japan/covid_jpn_total.csv") Currenly, OxCGRT dataset in Kaggle is provided as EXCEL file. We need to convert it to CSV file. The difference of primary/Kaggle datasets will be adjust using I will add |
Dear @ilyasst , import covsirphy as cs
# Set the directory to save the datasets
data_loader = cs.DataLoader("input")
# Population in each country
population_data = data_loader.population() README.md was also updated. |
Because this change was applied, I will close this issue. Thank you. |
Is your feature request related to a problem? Please describe.
Currently,
input.sh
works for Ubuntu (it might work on MacOS if SVN is available but I did not test it), however it can definitely not be used for Windows.Describe the solution you'd like
input.sh
could be written in python which would make it possible to execute it using any OS as long as the python environment is properly setup.The text was updated successfully, but these errors were encountered: