Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration frame stucked #17

Closed
shad-lp opened this issue Jun 7, 2021 · 7 comments
Closed

Configuration frame stucked #17

shad-lp opened this issue Jun 7, 2021 · 7 comments
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working

Comments

@shad-lp
Copy link

shad-lp commented Jun 7, 2021

Hello (again),

When I'm cliking on the wrench, I end up on the config menu but I can't navigate between tabs in the upper part of the frame.
Plus, of the six buttons on the landing config page only download config and reset local settings are effective.

I tried with Chrome and Firefox, normal and private mode. Same behaviour.
Using a reverse proxy to access dashy URL, I'll use an IP to see if it behaves differently.

@Lissy93 Lissy93 added the 🐛 Bug [ISSUE] Ticket describing something that isn't working label Jun 7, 2021
@Lissy93
Copy link
Owner

Lissy93 commented Jun 7, 2021

Hmm that's weird, not come across that before - sorry about that. Would you mind opening up the dev tools (usually F12), going to the console tab, and copy pasting the error message? That should show what's causing the issue.

@shad-lp
Copy link
Author

shad-lp commented Jun 7, 2021

There are errors indeed :

dashy_config_1

@shad-lp
Copy link
Author

shad-lp commented Jun 8, 2021

I can confirm that it's not related to the reverse proxy setup.
I can also confirm that it is not related to false-positive adblocking.

@shad-lp
Copy link
Author

shad-lp commented Jun 8, 2021

Another problem, when I open the config tab, I can't find a way to close it without reloading the page ?
I don't see any closing cross nor "close" button. Escape on keyboard does not work either.

@Lissy93 Lissy93 closed this as completed in dc15f29 Jun 8, 2021
Lissy93 added a commit that referenced this issue Jun 8, 2021
@Lissy93
Copy link
Owner

Lissy93 commented Jun 8, 2021

Really sorry about that- was my mistake. I've fixed it now with this PR. The updated Docker image should be pushed in a few minutes

@Lissy93 Lissy93 reopened this Jun 8, 2021
@Lissy93
Copy link
Owner

Lissy93 commented Jun 8, 2021

Okay the new image is now live on docker hub, so a fresh pull of :latest should fix this. That PR should also have fixed the issue with closing the popup too. To close the modal, just click anywhere outside of it, or press Esc. I will add a dedicated close button in a future PR, as I think that will be more intuitive. But let me know if that, or anything else is still not working

Thank you very much for all your feedback - I'm working on some unit tests at the moment, and that should prevent any regression bugs sneaking into future releases :)

@shad-lp
Copy link
Author

shad-lp commented Jun 8, 2021

Works perfectly, thank you.
I'm really enthousiast about your work, if I can help I'll do, I wish I were a developer and could directly write up push requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug [ISSUE] Ticket describing something that isn't working
Projects
None yet
Development

No branches or pull requests

2 participants