Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mobile] Layout tab not showing in portrait #19

Closed
shad-lp opened this issue Jun 8, 2021 · 2 comments · Fixed by #21
Closed

[Mobile] Layout tab not showing in portrait #19

shad-lp opened this issue Jun 8, 2021 · 2 comments · Fixed by #21

Comments

@shad-lp
Copy link

shad-lp commented Jun 8, 2021

When I open up Dashy on my mobile (Pixel 4a) in portrait view, I can't see the layout config menu :

dashy_config_tab

Portrait view :

Screenshot_20210608-153052

If I click on the "+", nothing happens, only the icon is changing :

Screenshot_20210608-153037

Landscape view :

Screenshot_20210608-152935

When I click on it the tab is correctly being displayed :

Screenshot_20210608-153003

@Lissy93
Copy link
Owner

Lissy93 commented Jun 8, 2021

Thanks for raising this. Yeah it was being hid by a media query, since I initially didn't think there was enough room on smaller screens, but actually the settings really do need to be visible on mobile.

I've implemented a fix (in 3b9b974), and will put it in a PR with some other fixes and stuff (hopefully) this evening, and I'll let you know when it's merged.

This is how it will behave after the changes:
Screen recording  new meida querys

@Lissy93 Lissy93 mentioned this issue Jun 9, 2021
10 tasks
@Lissy93
Copy link
Owner

Lissy93 commented Jun 9, 2021

This is fixed now :)

asterling8516 pushed a commit to asterling8516/dashy that referenced this issue Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants