Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

displayData ignored #7

Closed
shad-lp opened this issue May 27, 2021 · 3 comments
Closed

displayData ignored #7

shad-lp opened this issue May 27, 2021 · 3 comments

Comments

@shad-lp
Copy link

shad-lp commented May 27, 2021

Hello, first let me thank you for this shiny dashboard, I really love the whole feeling.
I'm struggling with how to customize frames with displayData. Here is my config tree :

dashy_disp_bug_1

The YAML version :

dashy_disp_bug_2

I would expect the "Informations" frame to have a 4x1 format with large icons, but nothing changes when I save the config :

dashy_disp_bug_3

PS : Btw there is a wording mistake, the message says "Changes seved successfully"

@Lissy93
Copy link
Owner

Lissy93 commented May 29, 2021

Thanks so much for raising this.

The issue is in fact my bad documentation, as I didn't really explain it well.
The rows and columns are in fact as a proportion of screen width / height, rather than by number of items within each tile. It's because I'm using CSS Grid Layout to make the page responsive.

For example:
Example of rows and cols

By default, on most screens there will be 4 columns, but large screens will have 5, and small will have 3 or 2 (depending on how much space there is), and small mobiles will just have 1. Rows are dynamic depending on how much content you have divided by number of columns.

In the meantime I'll update the docs, but in the future I would like to make the whole process much more intuitive. I'd not thought about measuring each section by number of items, as you expected, but I think that's a great idea :) And sorry for the confusion

P.s thanks for spotting the typo in the pop-up message, I've fixed that now :)

@Lissy93
Copy link
Owner

Lissy93 commented May 31, 2021

Hey @shadowKing001

Just to let you know, I've added some new data attributes that will fix this for you in #8 (specifically 10ec99d).

Under displayData for a given section, you can now specify layout: grid, and they use itemCountX to set how many items will display horizontally, and optionally itemCountY to do the same vertically.

Don't forget to update to the latest version. Hope that helps :)

@shad-lp
Copy link
Author

shad-lp commented May 31, 2021

Thanks a lot I'll look into it in the coming days. 👌

asterling8516 pushed a commit to asterling8516/dashy that referenced this issue Nov 23, 2023
Co-authored-by: Bjorn Lammers <walkxnl@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants