Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[labs/motion] flip-controller.js is missing in the npm release #1827

Closed
alangdm opened this issue Apr 30, 2021 · 4 comments
Closed

[labs/motion] flip-controller.js is missing in the npm release #1827

alangdm opened this issue Apr 30, 2021 · 4 comments

Comments

@alangdm
Copy link

alangdm commented Apr 30, 2021

Description

While trying to use @lit-labs/motion in a JS project, I noticed that I was getting the following error:

GET http://localhost:8000/node_modules/@lit-labs/motion/flip-controller.js net::ERR_ABORTED 404 (Not Found)

After looking at the node_modules folder, I noticed that while the other TS files have their counterpart JS files, flip-controller seems to be absent

https://unpkg.com/browse/@lit-labs/motion@1.0.0-rc.1/

Steps to Reproduce

  1. Install @lit-labs/motion from npm
  2. Import it like this
import { flip } from '@lit-labs/motion';
  1. The above-mentioned error occurs
@mabry1985
Copy link

This seems to be a duplicate of, or similar to, #1796

@Vac1911
Copy link

Vac1911 commented May 5, 2021

This seems to be a duplicate of, or similar to, #1796

I believe it is caused by the same issue, however this is reporting that the critical fix has should added to the npm package (I'm not 100% sure how npm releases work).

Edit: Also I am having the same issue.

@Vac1911
Copy link

Vac1911 commented May 5, 2021

Temporary work around (this is really bad practice)

Put this file into your node_modules/@lit-labs/motion folder. Make sure that the file is named flip-controller.js

For those wondering: the code in that gist was made by recompiling lit while I was working on an unrelated issue.

@alangdm
Copy link
Author

alangdm commented May 9, 2021

It seems rc2 fixed this issue so I'll close this, thanks a lot!

@alangdm alangdm closed this as completed May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants