Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[labs/react] Add back the reserved React property warning #3212

Closed
1 task done
justinfagnani opened this issue Aug 12, 2022 · 1 comment
Closed
1 task done

[labs/react] Add back the reserved React property warning #3212

justinfagnani opened this issue Aug 12, 2022 · 1 comment
Assignees

Comments

@justinfagnani
Copy link
Collaborator

Should this be an RFC?

  • This is not a substantial change

Which package is this a feature request for?

React (@lit-labs/react)

Description

#2800 removed our warning for reserved React property names because it changed how we detect custom element properties. We should add this back, but only in a dev build, which we'll need to set up for the react package.

Alternatives and Workarounds

n/a

@taylor-vann taylor-vann self-assigned this Nov 9, 2022
@taylor-vann
Copy link
Contributor

Curious if we can close this issue.

We don't iterate over the element like we didn't with #2800 which doesn't give us the opportunity to warn users about properties except for on component updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants