Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[labs/router] goto() and link() don't work for global routes #3352

Open
justinfagnani opened this issue Oct 13, 2022 · 0 comments
Open

[labs/router] goto() and link() don't work for global routes #3352

justinfagnani opened this issue Oct 13, 2022 · 0 comments

Comments

@justinfagnani
Copy link
Collaborator

justinfagnani commented Oct 13, 2022

Which package(s) are affected?

Other/unknown (please mention in description)

Description

See: https://github.com/lit/lit/tree/main/packages/labs/router#global-links

Global or absolute links don't need a link(url: string) form - an absolute URL can already be used in the href attribute of an <a> tag. But links within components shouldn't need to be tied to the specific URL layout - you should be able to describe the route by name and parameters. These names and parameters need to be nested to work with nested routes.

Reproduction

n/a

Workaround

n/a

Is this a regression?

No or unsure. This never worked, or I haven't tried before.

Affected versions

all

Browser/OS/Node environment

All browsers

@justinfagnani justinfagnani changed the title [labs/router] goto() and link() don't work for nested routes [labs/router] goto() and link() don't work for relative routes Oct 13, 2022
@justinfagnani justinfagnani changed the title [labs/router] goto() and link() don't work for relative routes [labs/router] goto() and link() don't work for global routes Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant