Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcutbar implementation crashes Exult on loading a savegame #21

Closed
DominusExult opened this issue Jun 29, 2015 · 7 comments
Closed
Assignees

Comments

@DominusExult
Copy link
Collaborator

e12c5bc make Exult crash on loading a savegame.

Steps to reproduce:

  • start a game
  • save
  • load this savegame

Something in the cleaning up of the gump is crashing according to Xcode.

@DominusExult
Copy link
Collaborator Author

Tried to debug this more but didn't succeed. Something with the gump is not right and the cleanup fails...

@litchie
Copy link
Owner

litchie commented Oct 15, 2015

This is in fact a regression. Will fix it as soon as possible.

@DominusExult
Copy link
Collaborator Author

Heya, thanks for the crash fix, but now the shortcutbar is no longer there on loading a savegame :)

@litchie
Copy link
Owner

litchie commented Oct 15, 2015

Are you sure? I still have it after load a game.

@litchie
Copy link
Owner

litchie commented Oct 15, 2015

If you are still seeing this bug, can you share a saved game file so that I can try to reproduce the problem?

@DominusExult
Copy link
Collaborator Author

Actually the shortcut gump does not show at all anymore with this change. Clean build, clean exult.cfg, either starting a new game or loading a savegame.
(btw. you comitted some autotool files (compile, config.guess, missing))

@DominusExult
Copy link
Collaborator Author

Just tested it again.
No luck with Xcode 7.0.1 and an iPad on iOS 9.0.2.
No luck with Xcode 7.1 beta 3 and an iPhone 6 on iOS 9.1 beta5.
In both cases the shortcut bar is no shown with these changes :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants