Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More architectures #1148

Closed
alcir opened this issue Oct 12, 2022 · 4 comments · Fixed by #1153
Closed

More architectures #1148

alcir opened this issue Oct 12, 2022 · 4 comments · Fixed by #1153

Comments

@alcir
Copy link

alcir commented Oct 12, 2022

I was trying to package lite-xl for Fedora Linux, but the build system fails when compiling for ppc64le and s390x architectures. Stating that

../src/main.c:107:6: error: #error "Please define -DLITE_ARCH_TUPLE."
  107 |     #error "Please define -DLITE_ARCH_TUPLE."

Sorry, but I'm not a developer, but I wonder if it would be possible to add

  #elif __s390x__
    #define ARCH_PROCESSOR "s390x"
  #elif __PPC64__
    #define ARCH_PROCESSOR "PPC64"

in addition to

lite-xl/src/main.c

Lines 85 to 93 in 0fc793d

#ifndef LITE_ARCH_TUPLE
#if __x86_64__ || _WIN64 || __MINGW64__
#define ARCH_PROCESSOR "x86_64"
#elif __i386__
#define ARCH_PROCESSOR "x86"
#elif __aarch64__
#define ARCH_PROCESSOR "aarch64"
#elif __arm__
#define ARCH_PROCESSOR "arm"

@adamharrison
Copy link
Member

adamharrison commented Oct 12, 2022

For non-standard architectures, the current procedure is to simply specify a LITE_ARCH_TUPLE define on the command line as part of your build; so just pass in -DLITE_ARCH_TUPLE="s390x-linux", or somesuch; that should fix the issue.

@Jan200101
Copy link
Contributor

Since you are packaging for Fedora these might be of interest:
https://pagure.io/lite-rpm/tree/master
https://copr.fedorainfracloud.org/coprs/sentry/lite/

If you are intending on submitting it to the Fedora repos I suggest either holding out till a new proper release is tagged or you backport Lua 5.4 support

@adamharrison
Copy link
Member

OK, so yeah, you can specify this as part of your meson build with meson setup <path> -Darch_tuple=s390x-linux.

Can you confirm that works for you?

@alcir
Copy link
Author

alcir commented Oct 13, 2022

OK, so yeah, you can specify this as part of your meson build with meson setup <path> -Darch_tuple=s390x-linux.

Can you confirm that works for you?

Yes!
-Darch_tuple=s390x-linux works, as well as -Darch_tuple=ppc64le-linux, -Darch_tuple=aarch64-linux and -Darch_tuple=x86_64-linux.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants