Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency in form submission #138

Open
antho1404 opened this issue Jan 20, 2023 · 1 comment
Open

Inconsistency in form submission #138

antho1404 opened this issue Jan 20, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@antho1404
Copy link
Member

antho1404 commented Jan 20, 2023

Some submit buttons in forms are disabled if there is an error in a form (aka a required field missing), but in other cases, the button is active, but when we submit, the error is displayed on each field.

Example:

  • Creation of an NFT: button always active, but error displayed on each field
  • Purchase of an NFT: button disabled if not enough money
@EmmanuelDrouin EmmanuelDrouin added the enhancement New feature or request label Jan 20, 2023
@ismailToyran
Copy link
Member

For this one, our UX solution is not enough I believe.
There are 2 components where we disable this button. Both checks if the user has enough balance or not.
We have alert component for that case on our other custom platform.

So if we remove disabled status to normalize the behaviour we should do one of the following;

  • Add alert component above button to let user know they don't have enough balance
  • Show error toaster after clicking the submit button to let user know they don't have enough balance
  • Show error message below or above submit button to let user know they don't have enough balance

We can not add input error message to normalize because even if we can add it on bid page, we can not add on checkout page as there is no input on checkout page. (unless multiple version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants