Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pagination on queries with hardcoded limit #363

Open
NicolasMahe opened this issue Aug 10, 2023 · 1 comment
Open

Implement pagination on queries with hardcoded limit #363

NicolasMahe opened this issue Aug 10, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@NicolasMahe
Copy link
Member

A few queries didn't have any limit implemented so I added an hardcoded limit of 100 to them in PR #362 to limit possible API related issues but without a pagination.

So we now need to implement a pagination system on those queries when needed.
I added the comment # TODO: implement pagination to the codebase to find those queries easily.
@NicolasMahe NicolasMahe added the enhancement New feature or request label Aug 10, 2023
@ismailToyran ismailToyran mentioned this issue Nov 20, 2023
Merged
1 task
@NicolasMahe
Copy link
Member Author

NicolasMahe commented Jan 23, 2024 •
edited
Loading

@ismailToyran could you check what other queries have hardcoded pagination. If that's only the collection's traits values I think we can close this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NicolasMahe