Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The price filter should also work for open offers right now it only applies to listings #578

Open
NicolasMahe opened this issue Feb 19, 2024 · 0 comments
Open

The price filter should also work for open offers right now it only applies to listings #578

NicolasMahe opened this issue Feb 19, 2024 · 0 comments

Comments

@NicolasMahe
Copy link
Member

NicolasMahe commented Feb 19, 2024 •
edited
Loading

The price filter should also work for open offers right now it only applies to listings.
So if I want to filter with has offer and price min 0.001 I can't

Originally posted by @antho1404 in #573 (comment)

Issue to confirm: I'm not sure it make sense to filter by bid price. Maybe the filter should be rename from "Price range" to "Listing price". Could also simplify the system by using USD as common currency (might need to save the offer's price in USD in database)
@NicolasMahe NicolasMahe mentioned this issue Feb 19, 2024
Merged
1 task
@NicolasMahe NicolasMahe changed the title The price filter should also work for open offers right now it only applies to listings. The price filter should also work for open offers right now it only applies to listings Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@NicolasMahe