Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: mount the SAQ UI #117

Open
peterschutt opened this issue Oct 25, 2022 · 2 comments
Open

Enhancement: mount the SAQ UI #117

peterschutt opened this issue Oct 25, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@peterschutt
Copy link
Contributor

SAQ has a UI which is an aiohttp Application object. Unfortunately these are not asgi apps: aio-libs/aiohttp#2902

There is https://github.com/mosquito/aiohttp-asgi, or might need an alternate implementation of the UI that could be delivered as a starlite application config plugin.

@peterschutt peterschutt added the enhancement New feature or request label Oct 25, 2022
@albcunha
Copy link

albcunha commented Dec 3, 2022

I´m sorry if I´m talking non-sense as I´m a beginner. But maybe wouldn´t it be better to separate the worker logic from starlite application?

I followed this tutorial https://github.com/fcakyon/flask-redis-docker and found it very easy to implement changes. If your worker is doing ML, sometimes you need to specify a GPU to it.

Also, creating a new worker was very easy. All I had to do was add a new container with same image and change command with a new name.

@peterschutt
Copy link
Contributor Author

Hey @albcunha - if your workers are doing CPU bound work it definitely would make sense to have your worker in a separate process. If the worker does mainly IO bound stuff, then this pattern should be just fine.

@Goldziher Goldziher changed the title Feat: mount the SAQ UI Enhancement: mount the SAQ UI Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants