Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: support HTML media type in redirect #1451

Closed
Goldziher opened this issue Apr 5, 2023 · 4 comments
Closed

Enhancement: support HTML media type in redirect #1451

Goldziher opened this issue Apr 5, 2023 · 4 comments
Assignees
@sonpro1296
Labels
Enhancement This is a new feature or request Good First Issue This is good for newcomers to take on Help Wanted 🆘 This is good for people to work on

Comments

@Goldziher
Copy link
Contributor

Summary

We currently do not support MediaType.HTML in the Redirect class / response, and this value is ignored (we do TEXT always). We should add support for HTML redirects as well.

Basic Example

No response

Drawbacks and Impact

None

Unresolved questions

No response
@Goldziher Goldziher added Enhancement This is a new feature or request Help Wanted 🆘 This is good for people to work on Good First Issue This is good for newcomers to take on labels Apr 5, 2023
@sonpro1296
Copy link
Contributor

Hi, can I work on this?

@Goldziher
Copy link
Contributor Author

Hi, can I work on this?

Sure, I'll assign you

@sonpro1296
Copy link
Contributor

PR for this is merged: #1474

@cofin
Copy link
Member

cofin commented Apr 10, 2023

closed by #1474

Thanks for the work on this!

@cofin cofin closed this as completed Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sonpro1296 sonpro1296

Labels
Enhancement This is a new feature or request Good First Issue This is good for newcomers to take on Help Wanted 🆘 This is good for people to work on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cofin @sonpro1296 @Goldziher