Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for "Message Flashing" #1455

Closed
4n1qz5skwv opened this issue Apr 7, 2023 Discussed in #1454 · 6 comments · Fixed by #3145
Closed

Add support for "Message Flashing" #1455

4n1qz5skwv opened this issue Apr 7, 2023 Discussed in #1454 · 6 comments · Fixed by #3145
Assignees
@euri10
Labels
Enhancement This is a new feature or request Middleware This is related to our middleware
Milestone
2.8.0

Comments

@4n1qz5skwv
Copy link

4n1qz5skwv commented Apr 7, 2023 •
edited by polar-sh bot

Discussed in https://github.com/orgs/litestar-org/discussions/1454

Originally posted by 4n1qz5skwv April 6, 2023
https://flask.palletsprojects.com/en/2.2.x/patterns/flashing/

flash('Invalid password provided', 'error')

How to do this LiteStar?

Fund with Polar
@v3ss0n
Copy link
Contributor

v3ss0n commented Apr 7, 2023 •
edited

I believe this framework is not designed for this . This is (mostly) API framework , hence backend . Why it needs a flashing helper for frotnend ?

@provinzkraut provinzkraut added the Enhancement This is a new feature or request label Apr 7, 2023
@Goldziher Goldziher changed the title How to do "Message Flashing" like flask? Add support for "Message Flashing" Apr 9, 2023
@Goldziher
Copy link
Contributor

This is not going to be supported probably - what do you think @provinzkraut ?

@provinzkraut
Copy link
Member

I think it could be fine in contrib if someone wants to add this, or we can create a "recipe" for it. It's easy enough to implement with request local state and a custom response class.

@Goldziher Goldziher added Help Wanted 🆘 This is good for people to work on Good First Issue This is good for newcomers to take on labels Apr 11, 2023
@provinzkraut
Copy link
Member

Why has this been closed?

@Goldziher
Copy link
Contributor

Why has this been closed?

It's stale and no one showed interest

@JacobCoffee JacobCoffee mentioned this issue Oct 30, 2023
Closed
@euri10 euri10 mentioned this issue Feb 27, 2024
Merged
@JacobCoffee JacobCoffee reopened this Mar 10, 2024
@JacobCoffee JacobCoffee removed Help Wanted 🆘 This is good for people to work on Good First Issue This is good for newcomers to take on labels Mar 10, 2024
@JacobCoffee JacobCoffee added this to the 2.8.0 milestone Mar 10, 2024
@JacobCoffee JacobCoffee added the Middleware This is related to our middleware label Mar 10, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2024

A fix for this issue has been released in v2.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@euri10 euri10

Labels
Enhancement This is a new feature or request Middleware This is related to our middleware
Projects
Overview
Status: Closed
Milestone
2.8.0
Development

Successfully merging a pull request may close this issue.

feat: add flash plugin euri10/litestar
6 participants
@v3ss0n @euri10 @provinzkraut @Goldziher @JacobCoffee @4n1qz5skwv