-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement: Add Sentry
integration for 2.0
#1514
Comments
I dont think this is an issue for this repository. Sentry is a for-profit company, and we should not contribute to them out of our own charity. Please open an issue on the sentry side of the fence, and they can take it from there - or not. |
@provinzkraut Does the current integration for Starlite need major modifications or it's just a matter of renaming |
I asked the question because we need this (at the company I work for) and we're considering contributing, I just wanted to have an idea on the effort needed, considering that we're new to Litestar and never contributed to Sentry. Thanks. |
I'm a heavy user of sentry also, so would like to see this done. I'd have to look at the code more thoroughly to comment, but I'd imagine there will be some fairly significant changes required as starlite -> litestar was a bit of a jump. |
It would be welcome and we could help with the transition when needed. |
I tried to adapt the implementation mentioned in https://github.com/getsentry/sentry-python/blob/f570a9966252920bdb221101d596eb029497b0e9/sentry_sdk/integrations/starlite.py#L51 https://gist.github.com/bpereto/8b49893f4a19740c19bf336af94aa95b#file-sentry-py I can tell that the errors do show up :) |
@bpereto Do you need a hand with this one? |
@kedod you might work with @guacs as well. There is a thread in the development discord channel. Happy to have anyone help or maybe even just take this if they have the capacity! |
I'm not sure how the internals of litestar work, but my implementation attempt seems do it's job. maybe you know the framework better and how to implement it correctly? Im unsure if the references are the newest versions. |
@kedod if you want to take this, please feel free :) |
I was expecting adding SentryAsgiMiddleware to the list of middlewares to have at least some effect, but no. |
The logging integration gives you something, but obviously not ideal as no spans etc. I spoke with one of their engineers at pycon, and he mentioned they might be exposing some new apis that would help us to build an integration without monkey-patching the application (which would be my preference). I'll be watching that space, but as a sentry user myself, this is a problem I'd like to see solved too. |
OK, looks like I forgot to configure DSN :D If one was to contribute to the integration:
I like Litestar code, but I know nothing about sentry internals. |
Summary
We have a sentry integration for 1.x. We need to update that integration, but we did not write any docs.
Basic Example
Please follow the Sentry Integration Guide with special emphasis on the docs
Per the Sentry Integration Guide:
Write the docs. Answer the following questions:
Drawbacks and Impact
N/A
Unresolved questions
The text was updated successfully, but these errors were encountered: