Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement : DTO - private properties and methods should be excluded by default. #1768

Closed
v3ss0n opened this issue Jun 1, 2023 · 1 comment · Fixed by #1777
Closed

Enhancement : DTO - private properties and methods should be excluded by default. #1768

v3ss0n opened this issue Jun 1, 2023 · 1 comment · Fixed by #1777
Assignees
Labels
Enhancement This is a new feature or request
Milestone

Comments

@v3ss0n
Copy link
Contributor

v3ss0n commented Jun 1, 2023

Summary

Identifiers which are considered private - starts with _ should be mark as private by default , unless required.

Basic Example

class User(UUIDAuditBase):
    """User Model."""
    email: Mapped[str] = mapped_column(unique=True)
    name: Mapped[str | None]
    _private_name: Mapped[str | None]``` # <--- should be marked as `mark.private`

Drawbacks and Impact

No response

Unresolved questions

No response

@v3ss0n v3ss0n added the Enhancement This is a new feature or request label Jun 1, 2023
@peterschutt peterschutt self-assigned this Jun 4, 2023
@peterschutt peterschutt added this to the 2.0 milestone Jun 4, 2023
@v3ss0n
Copy link
Contributor Author

v3ss0n commented Jun 7, 2023

Nice , gonna try it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This is a new feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants