Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Should the Makefile be included in the sdist build? #2432

Open
cofin opened this issue Oct 12, 2023 · 2 comments
Open

Bug: Should the Makefile be included in the sdist build? #2432

cofin opened this issue Oct 12, 2023 · 2 comments
Labels
Bug 🐛 This is something that is not working as expected Infrastructure This is Infrastructure related

Comments

@cofin
Copy link
Member

cofin commented Oct 12, 2023

https://github.com/litestar-org/litestar/blob/6a4aa0087f6dd15ffea8b4fe3a5c1684b6a5d03b/pyproject.toml#L153C15-L153C15

Note

Check out all issues funded or available for funding here: https://polar.sh/litestar-org

  • If you would like to see an issue prioritized, make a pledge towards it!
  • We receive the pledge once the issue is completed & verified
Fund with Polar
@peterschutt
Copy link
Contributor

I don't feel like it should have to be there, unless we do something like subprocess.run(["make", "..."]) somewhere internally?

@provinzkraut
Copy link
Member

provinzkraut commented Oct 16, 2023

I agree with @peterschutt, it should not be there. Same goes for the tests?

@JacobCoffee JacobCoffee added Bug 🐛 This is something that is not working as expected Infrastructure This is Infrastructure related labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 This is something that is not working as expected Infrastructure This is Infrastructure related
Projects
Status: Backlog
Development

No branches or pull requests

4 participants