Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(typing): Internal type exposed on public interface #3373

Open
peterschutt opened this issue Apr 11, 2024 · 0 comments
Open

bug(typing): Internal type exposed on public interface #3373

peterschutt opened this issue Apr 11, 2024 · 0 comments
Labels
Bug 🐛 This is something that is not working as expected

Comments

@peterschutt
Copy link
Contributor

peterschutt commented Apr 11, 2024

We expose SchemaCreator on DTOFactory.create_openapi_schema()`, but its an undocumented type.

We should replace it with a protocol.

          This weird wording is because `SchemaFactory` is an internal type, but its exposed on a public interface here. We should probably replace the annotation with a Protocol.

Originally posted by @peterschutt in #3371 (comment)


Note

While we are open for sponsoring on GitHub Sponsors and
OpenCollective, we also utilize Polar.sh to engage in pledge-based sponsorship.

Check out all issues funded or available for funding on our Polar.sh dashboard

  • If you would like to see an issue prioritized, make a pledge towards it!
  • We receive the pledge once the issue is completed & verified
  • This, along with engagement in the community, helps us know which features are a priority to our users.
Fund with Polar
@peterschutt peterschutt added the Bug 🐛 This is something that is not working as expected label Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🐛 This is something that is not working as expected
Projects
None yet
Development

No branches or pull requests

1 participant