import fails because of missing sqlalchemy

[vincentsarago]

I guess #27 introduced a bug which result in MissingDependencyException: sqlalchemy is not installed when I try to import some Starlite submodule

In [1]: from starlite.controller import Controller
---------------------------------------------------------------------------
ImportError                               Traceback (most recent call last)
~/Dev/DevSeed/starlite/starlite/plugins/sql_alchemy.py in <module>
     28     )
---> 29     from sqlalchemy.orm import DeclarativeMeta, Mapper
     30     from sqlalchemy.sql.type_api import TypeEngine

ImportError: cannot import name 'DeclarativeMeta' from 'sqlalchemy.orm' (/Users/vincentsarago/Dev/venv/python38/lib/python3.8/site-packages/sqlalchemy/orm/__init__.py)

The above exception was the direct cause of the following exception:

MissingDependencyException                Traceback (most recent call last)
<ipython-input-1-fceda90b0bd9> in <module>
----> 1 from starlite.controller import Controller

~/Dev/DevSeed/starlite/starlite/__init__.py in <module>
      1 # flake8: noqa
----> 2 from .app import Starlite
      3 from .config import CORSConfig, OpenAPIConfig
      4 from .controller import Controller
      5 from .dto import DTOFactory

~/Dev/DevSeed/starlite/starlite/app.py in <module>
     18 from typing_extensions import Type
     19 
---> 20 from starlite.config import CORSConfig, OpenAPIConfig
     21 from starlite.enums import MediaType
     22 from starlite.exceptions import HTTPException

~/Dev/DevSeed/starlite/starlite/config.py in <module>
     16 from typing_extensions import Type
     17 
---> 18 from starlite.openapi.controller import OpenAPIController
     19 
     20 

~/Dev/DevSeed/starlite/starlite/openapi/controller.py in <module>
      2 from orjson import OPT_INDENT_2, dumps
      3 
----> 4 from starlite.controller import Controller
      5 from starlite.enums import MediaType, OpenAPIMediaType
      6 from starlite.exceptions import ImproperlyConfiguredException

~/Dev/DevSeed/starlite/starlite/controller.py in <module>
      6 from starlite.response import Response
      7 from starlite.types import Guard, ResponseHeader
----> 8 from starlite.utils import normalize_path
      9 
     10 if TYPE_CHECKING:  # pragma: no cover

~/Dev/DevSeed/starlite/starlite/utils/__init__.py in <module>
      2 from .model import convert_dataclass_to_model, create_parsed_model_field
      3 from .sequence import find_index, unique
----> 4 from .signature import SignatureModel, create_function_signature_model
      5 from .url import join_paths, normalize_path
      6 

~/Dev/DevSeed/starlite/starlite/utils/signature.py in <module>
      8 
      9 from starlite.exceptions import ImproperlyConfiguredException
---> 10 from starlite.plugins.base import PluginMapping, PluginProtocol, get_plugin_for_value
     11 
     12 

~/Dev/DevSeed/starlite/starlite/plugins/__init__.py in <module>
      1 from .base import PluginMapping, PluginProtocol, get_plugin_for_value
----> 2 from .sql_alchemy import SQLAlchemyPlugin
      3 
      4 __all__ = [
      5     "PluginMapping",

~/Dev/DevSeed/starlite/starlite/plugins/sql_alchemy.py in <module>
     30     from sqlalchemy.sql.type_api import TypeEngine
     31 except ImportError as exc:  # pragma: no cover
---> 32     raise MissingDependencyException("sqlalchemy is not installed") from exc
     33 
     34 

MissingDependencyException: sqlalchemy is not installed

I believe sqlalchemy is only a plugin 🤷

[Goldziher]

@vincentsarago -- silly me. I fixed this issue and released v0.4.1. Issue was caused by including the plugin in the main __init__.py

[Goldziher]

Can you please test and close the issue if applicable?

[vincentsarago]

🙏 yep it's good now :-)