Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhancement] logging setup to be non-blocking #77

Closed
Goldziher opened this issue Feb 3, 2022 · 3 comments · Fixed by #95
Closed

[enhancement] logging setup to be non-blocking #77

Goldziher opened this issue Feb 3, 2022 · 3 comments · Fixed by #95
Labels
Enhancement This is a new feature or request Good First Issue This is good for newcomers to take on Help Wanted 🆘 This is good for people to work on

Comments

@Goldziher
Copy link
Contributor

The default logging config, which is just a simple abstraction on top of DictConfig, creates a standard python logger. The issue with this setup is that python logging is sync and blocking. This means that the logging config needs to be updated to setup a QueueHandler.

Here are some resources regarding this:

  1. https://rob-blackbourn.medium.com/how-to-use-python-logging-queuehandler-with-dictconfig-1e8b1284e27a
  2. https://stackoverflow.com/questions/25585518/python-logging-logutils-with-queuehandler-and-queuelistener
  3. https://betterprogramming.pub/power-up-your-python-logging-6dd3ed38f322
@Goldziher Goldziher added Enhancement This is a new feature or request Help Wanted 🆘 This is good for people to work on Good First Issue This is good for newcomers to take on labels Feb 3, 2022
@Goldziher Goldziher changed the title Update logging setup to be non-blocking [Update] logging setup to be non-blocking Feb 3, 2022
@JonasKs
Copy link
Contributor

JonasKs commented Feb 3, 2022

We use this library with logstash, it's awesome.

@madlad33
Copy link
Contributor

madlad33 commented Feb 4, 2022

Hello, I would like to contribute and work on this issue.

@Goldziher
Copy link
Contributor Author

Hello, I would like to contribute and work on this issue.

Great, looking forward to your PR 😃

@Goldziher Goldziher changed the title [Update] logging setup to be non-blocking [enhancement] logging setup to be non-blocking Feb 6, 2022
@madlad33 madlad33 mentioned this issue Feb 9, 2022
Closed
@madlad33 madlad33 mentioned this issue Feb 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement This is a new feature or request Good First Issue This is good for newcomers to take on Help Wanted 🆘 This is good for people to work on
Projects
None yet
Milestone
No milestone
3 participants
@JonasKs @Goldziher @madlad33