Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancment: Support arbitrary json libraries #851

Closed
v3ss0n opened this issue Nov 23, 2022 · 2 comments
Closed

Enhancment: Support arbitrary json libraries #851

v3ss0n opened this issue Nov 23, 2022 · 2 comments
Labels
Enhancement This is a new feature or request
Milestone
2.0

Comments

@v3ss0n
Copy link
Contributor

v3ss0n commented Nov 23, 2022

What's the feature you'd like to ask for.

Starlite should be able to choose a default json decoder and make it configurable.
Currently Starlite cannot run on PyPy due to orjson compilation problem and orJson states that they are not going to make pypy compatible anytime soon ijl/orjson#90 , so I couldn't test starlite on pypy which could see a good deal of performance improvement on pypy.

Additional context

Should orjson be optional dependency and starlite should be able to configure any json backends ?
@v3ss0n v3ss0n added Enhancement This is a new feature or request Triage Required 🏥 This requires triage labels Nov 23, 2022
@v3ss0n v3ss0n changed the title Ability to choose default json encoder / decoder Configuration to choose default json encoder / decoder Nov 23, 2022
@provinzkraut provinzkraut removed the Triage Required 🏥 This requires triage label Nov 23, 2022
@provinzkraut provinzkraut changed the title Configuration to choose default json encoder / decoder Enhancment: Configuration to choose default json encoder / decoder Nov 23, 2022
@provinzkraut provinzkraut changed the title Enhancment: Configuration to choose default json encoder / decoder Enhancment: Support arbitrary json libraries Nov 23, 2022
@provinzkraut provinzkraut added this to the 2.0 milestone Nov 26, 2022
@Goldziher
Copy link
Contributor

Well, there is nothing preventing users from subclassing response. Do we need to add anything extra?

@Goldziher
Copy link
Contributor

Ok, im closing this since its easy enough to subclass a response and use a different serializer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement This is a new feature or request
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
3 participants
@v3ss0n @provinzkraut @Goldziher