Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pre-commit check to find and delete unused strings in strings.en.yaml file #4550

Open
Saranya-jena opened this issue Mar 22, 2024 · 1 comment · May be fixed by #4596
Open

Add pre-commit check to find and delete unused strings in strings.en.yaml file #4550

Saranya-jena opened this issue Mar 22, 2024 · 1 comment · May be fixed by #4596
Labels
good first issue

Comments

@Saranya-jena
Copy link
Contributor

Add pre-commit check to find and delete unused strings in strings.en.yaml file
@kartikaysaxena
Copy link
Contributor

Would love to work on this! Also for an initial approach, I think most of the strings in strings.en.yaml are mapped in chaoscenter/web/src/strings/types.ts, should the pre-commit script search the string identifiers from strings.en.yaml in the entire codebase or just chaoscenter/web/src/strings/types.ts as it has all of the string identifiers mapped.

@shruti2522 shruti2522 linked a pull request Apr 23, 2024 that will close this issue
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated pre-commit.sh to check for unused strings in strings.en.yaml shruti2522/litmus
2 participants
@Saranya-jena @kartikaysaxena