Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to formatting text in probe card #4560

Open
namkyu1999 opened this issue Mar 31, 2024 · 5 comments · May be fixed by #4578
Open

Need to formatting text in probe card #4560

namkyu1999 opened this issue Mar 31, 2024 · 5 comments · May be fixed by #4578
Assignees
@satya19977
Labels
bug front-end-issue good first issue

Comments

@namkyu1999
Copy link
Member

What happened:

When we named probes long, ugly formatting happened in chaoscenter. String formatting is needed

Screenshot 2024-03-31 at 3 19 41 PM

Anything else we need to know?:

Anyone who wants to contribute to this issue, Let me know :)
I think we need to edit this file

https://github.com/litmuschaos/litmus/blob/master/chaoscenter/web/src/views/ExperimentCreationFaultConfiguration/Tabs/Probes/Probes.tsx
@namkyu1999 namkyu1999 changed the title need to text formatting in probe card Need to formatting text in probe card Mar 31, 2024
@satya19977
Copy link

satya19977 commented Apr 8, 2024 •
edited

Hey @namkyu1999. Can you assign the issue to me ?

@namkyu1999
Copy link
Member Author

sure, go ahead @satya19977 😄

@ChaitanyaD48
Copy link
Contributor

ChaitanyaD48 commented Apr 11, 2024 •
edited

Hey @satya19977 What's the current status? Should I raise the PR since I've solved the issue?

@satya19977
Copy link

satya19977 commented Apr 11, 2024 •
edited

Hey @ChaitanyaD48 . Please go ahead and raise the PR. I am just curious, what's the solution? Did you change the line clamp from 1 to 2?

@ChaitanyaD48 ChaitanyaD48 linked a pull request Apr 11, 2024 that will close this issue
Open
9 tasks
@ChaitanyaD48
Copy link
Contributor

ChaitanyaD48 commented Apr 11, 2024 •
edited

@satya19977 I modified the Probes.module.scss file to add extra space for the probe name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@satya19977 satya19977

Labels
bug front-end-issue good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improved Probe Card Text Formatting ChaitanyaD48/litmus
3 participants
@namkyu1999 @ChaitanyaD48 @satya19977