Skip to content
This repository has been archived by the owner on Sep 30, 2019. It is now read-only.

Eslint error on graphql-phone-type dependency #47

Open
abelovic opened this issue Nov 29, 2018 · 7 comments
Open

Eslint error on graphql-phone-type dependency #47

abelovic opened this issue Nov 29, 2018 · 7 comments

Comments

@abelovic
Copy link

I'm getting this error when trying to install anything that uses the appsync-emulator-serverless package as a dependency. It looks like it is pointing to a forked package of the graphql-phone-type repo which may not have been updated or is broken.

$ npm run clean && npm run lint && npm run build
[###############################################################----------------------------------------------] 534/928

graphql-phone-type@0.0.2 clean C:\Users\up175\AppData\Local\Yarn\Cache\v2.tmp\ba08b149d9e36e6bca89db26836f5f97.daaa07a9705b8a4669acd5f98a599ab443cb31d6.prepare
rimraf lib dist es coverage

graphql-phone-type@0.0.2 lint C:\Users\up175\AppData\Local\Yarn\Cache\v2.tmp\ba08b149d9e36e6bca89db26836f5f97.daaa07a9705b8a4669acd5f98a599ab443cb31d6.prepare
eslint src demo

C:\Users\up175\AppData\Local\Yarn\Cache\v2.tmp\ba08b149d9e36e6bca89db26836f5f97.daaa07a9705b8a4669acd5f98a599ab443cb31d6.prepare\src\index.js
1:65 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
2:66 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
3:1 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
4:60 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
5:31 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
6:30 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
7:91 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
8:4 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
9:1 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
10:47 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
11:25 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
12:54 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
13:4 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
14:18 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
15:78 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
16:4 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
17:1 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
18:16 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
19:3 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
20:1 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
21:58 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
22:30 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
23:43 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
24:12 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
25:12 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
26:19 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
27:28 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
28:22 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
29:29 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
30:16 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
31:11 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
32:40 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
33:9 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
34:29 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
35:22 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
36:29 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
37:16 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
38:11 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
39:40 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
40:9 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
41:51 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
42:8 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
43:4 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
44:2 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
45:1 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
46:33 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style

C:\Users\up175\AppData\Local\Yarn\Cache\v2.tmp\ba08b149d9e36e6bca89db26836f5f97.daaa07a9705b8a4669acd5f98a599ab443cb31d6.prepare\demo\index.js
1:31 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
2:39 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
3:31 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
4:1 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
5:23 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
6:40 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
7:98 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
8:4 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
9:1 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
10:30 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
11:10 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
12:18 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
13:5 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style

C:\Users\up175\AppData\Local\Yarn\Cache\v2.tmp\ba08b149d9e36e6bca89db26836f5f97.daaa07a9705b8a4669acd5f98a599ab443cb31d6.prepare\demo\schema.js
1:9 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
2:21 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
3:17 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
4:18 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
5:35 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
6:1 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
7:35 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
8:33 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
9:19 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
10:21 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
11:20 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
12:33 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
13:30 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
14:24 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
15:12 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
16:44 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
17:9 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
18:22 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
19:33 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
20:32 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
21:24 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
22:12 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
23:37 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
24:9 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
25:26 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
26:33 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
27:36 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
28:25 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
29:25 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
30:12 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
31:44 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
32:9 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
33:28 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
34:33 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
35:38 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
36:25 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
37:25 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
38:12 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
39:38 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
40:8 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
41:8 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
42:6 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style
43:4 error Expected linebreaks to be 'LF' but found 'CRLF' linebreak-style

102 problems (102 errors, 0 warnings)
102 errors, 0 warnings potentially fixable with the --fix option.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! graphql-phone-type@0.0.2 lint: eslint src demo
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the graphql-phone-type@0.0.2 lint script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

@cbaron
Copy link
Contributor

cbaron commented Nov 29, 2018

@abelovic -- Good to know another appsync emulator user!

Which version of the package are you using?

Would it be possible to utilize yarn instead of npm?

@abelovic
Copy link
Author

abelovic commented Nov 29, 2018

You should be able to reproduce using your own example: https://github.com/ConduitVC/appsync-serverless-emulator-example

It is still pointing to 0.7.1 but even after I updated to 0.7.8 I'm still getting the same error :(

Also I always use yarn :)

@cbaron
Copy link
Contributor

cbaron commented Nov 29, 2018

Please walk me through how to reproduce, and include your eslint config.

This example does not include a linter.

Normally, a linter does not worry about node_modules.

If you checkout the master branch of this repo, and run the linter, everything passes from what I can tell.

@cbaron
Copy link
Contributor

cbaron commented Nov 30, 2018

@abelovic -- want to follow up and see if you've been able to resolve this issue. How are things? Let me know if I can help.

@cbaron cbaron closed this as completed Dec 4, 2018
@randomStone
Copy link

Hey @cbaron
I'm getting this same issue as OP with the only difference being I used npm instead of yarn,
I ran npm install and yarn install on your example from your comment and I still got the error.

@cbaron
Copy link
Contributor

cbaron commented Jan 4, 2019

@randomStone, sorry to hear your having issues. Can you be more specific about what's happening on your machine so that I can try to reproduce? I would suggest using yarn or npm, not both.

@cbaron cbaron reopened this Jan 5, 2019
@cbaron
Copy link
Contributor

cbaron commented Jan 5, 2019

@randomStone -- I'm seeing a flaky issue with this package on a project that I'm working on. It made a CI build fail:

error An unexpected error occurred: "https://registry.yarnpkg.com/libphonenumber-js/-/libphonenumber-js-0.4.52.tgz: ENOENT: no such file or directory, utime '/home/circleci/.cache/yarn/v1/npm-libphonenumber-js-0.4.52-19aec62488f039faee243df14d68ae56d77780a6/build/validate.js.map'".

When I reran the build, everything worked.

Perhaps we should use a different library. I will try to get to it soon, feel free to put up a PR that uses a library which works for you.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants