reimplement non-conflicting fix for #53 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Super annoying that 6 months out this two line fix hasn't been merged in. Any chance this can be merged? |
|
@mikecx The project seems abandoned to me. Have you found a decent alternative? |
|
@denisftw Agreed, definitely looks dead. We're on the CatchRelease branch now but possibly looking to move to React Portal Popover as Portals are supposed to be used for this sort of thing. |
|
@mikecx Thanks, I didn't know about the CatchRelease fork. React Portal Popover doesn't look very active though. I was thinking of react-popper, but its API is definitely more complicated. |
jasonkuhrt
approved these changes
May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really need this fix, so here is a reimplementation of #74 that doesn't conflict. All credit goes to @stephen though.