Move assets to app/assets for Rails 4 #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Rails 4 "loose" assets (images, fonts, etc.) in `lib` and `vendor` are no longer precompiled by default. Rails Engines should put their assets in their own app/assets. See: rails/rails#7968
|
Is there any side effects to Rails 3.x? |
|
Rails engines already look for assets in the gem's |
littlebtc
added a commit
that referenced
this pull request
Feb 20, 2013
Move assets to app/assets for Rails 4
|
Sounds good. Merged, and I will test it again before the new gem is released. |
|
Great, and thanks! I'm actually using this gem with both a Rails 4 app (where I've verified this fix) and several Rails 3.2 apps. I can verify on one of them, if you'd like - or you can feel free to do that yourself, naturally. Thanks again! |
|
Version 3.0.2.2 released to RubyGems.org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Rails 4 "loose" assets (images, fonts, etc.) in
libandvendorare no longer precompiled by default. Rails Engines should put their
assets in their own
app/assets.See: rails/rails#7968