Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nothing happened when user didn't install "Permission Nanny" #1

Closed
pcqpcq opened this issue Jul 20, 2015 · 2 comments
Closed

Nothing happened when user didn't install "Permission Nanny" #1

pcqpcq opened this issue Jul 20, 2015 · 2 comments

Comments

@pcqpcq
Copy link

pcqpcq commented Jul 20, 2015

I think Permission Nanny is a good idea.
it will be useful if all developers follow the rules.


but, nothing happened when user didn't install "Permission Nanny", any toast or dialog are not shown.
it will let the user confusion.


how about show a dialog to show the way to install "Permission Nanny"?

@littledot
Copy link
Owner

I try not to add any UI code into the SDK because I do not feel confident I know the desired flow for client apps, especially when the narrative is from them. For example, a Dialog may sound reasonable to you, but another may prefer Snackbars.

Hence all I did was include a convenience method for clients to check if the server is installed on the device (in NannyClient.java).

One thing I should definitely do is return a 404 Not Found immediately when the server is not installed. As for the UI, I'll need to consider your proposal for showing a dialog.

@pcqpcq
Copy link
Author

pcqpcq commented Jul 21, 2015

em, i think you are right.
what you have did now is a good choice 👍

@pcqpcq pcqpcq closed this as completed Jul 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants