Skip to content

Commit

Permalink
Tweaked on-disk config comments for consistency
Browse files Browse the repository at this point in the history
- Prefer "defaults to blablabla when zero" to hint that this is the
  default state when both explicitly set to zero and implicitly set to
  zero thanks to C's initializers.

- Prefer "disk" when referencing something stored "on disk". Other terms
  can quickly get ambiguous. Except maybe "block device"...
  • Loading branch information
geky committed Apr 17, 2024
1 parent 01b6a47 commit 1bc1493
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions lfs.h
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ typedef uint32_t lfs_block_t;
#endif

// Maximum size of custom attributes in bytes, may be redefined, but there is
// no real benefit to using a smaller LFS_ATTR_MAX. Limited to <= 1022.
// no real benefit to using a smaller LFS_ATTR_MAX. Limited to <= 1022. Stored
// in superblock and must be respected by other littlefs drivers.
#ifndef LFS_ATTR_MAX
#define LFS_ATTR_MAX 1022
#endif
Expand Down Expand Up @@ -203,8 +204,8 @@ struct lfs_config {
// program sizes.
lfs_size_t block_size;

// Number of erasable blocks on the device.
// If 0, will attempt to infer block_count from existing filesystem.
// Number of erasable blocks on the device. Defaults to block_count stored
// on disk when zero.
lfs_size_t block_count;

// Number of erase cycles before littlefs evicts metadata logs and moves
Expand Down Expand Up @@ -253,18 +254,18 @@ struct lfs_config {

// Optional upper limit on length of file names in bytes. No downside for
// larger names except the size of the info struct which is controlled by
// the LFS_NAME_MAX define. Defaults to LFS_NAME_MAX when zero. Stored in
// superblock and must be respected by other littlefs drivers.
// the LFS_NAME_MAX define. Defaults to LFS_NAME_MAX or name_max stored on
// disk when zero.
lfs_size_t name_max;

// Optional upper limit on files in bytes. No downside for larger files
// but must be <= LFS_FILE_MAX. Defaults to LFS_FILE_MAX when zero. Stored
// in superblock and must be respected by other littlefs drivers.
// but must be <= LFS_FILE_MAX. Defaults to LFS_FILE_MAX or file_max stored
// on disk when zero.
lfs_size_t file_max;

// Optional upper limit on custom attributes in bytes. No downside for
// larger attributes size but must be <= LFS_ATTR_MAX. Defaults to
// LFS_ATTR_MAX when zero.
// LFS_ATTR_MAX or attr_max stored on disk when zero.
lfs_size_t attr_max;

// Optional upper limit on total space given to metadata pairs in bytes. On
Expand Down

0 comments on commit 1bc1493

Please sign in to comment.