Skip to content

Commit

Permalink
Changed test_runner to run with -Pnone,linear by default
Browse files Browse the repository at this point in the history
The linear powerloss heuristic provides very good powerloss coverage
without a significant runtime hit, so there's really no reason to run
the tests without -Plinear.

Previous behavior can be accomplished with an explicit -Pnone.
  • Loading branch information
geky committed Dec 7, 2022
1 parent 9b687dd commit cda2f6f
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/test.yml
Expand Up @@ -92,8 +92,7 @@ jobs:
- name: test
run: |
make clean
# TODO include this by default?
TESTFLAGS="$TESTFLAGS -Pnone,linear" make test
make test
# collect coverage info
#
Expand Down Expand Up @@ -372,7 +371,7 @@ jobs:
# on one geometry
- name: test-valgrind
run: |
TESTFLAGS="$TESTFLAGS -Gdefault --valgrind" make test
TESTFLAGS="$TESTFLAGS --valgrind -Gdefault -Pnone" make test
# test that compilation is warning free under clang
# run with Clang, mostly to check for Clang-specific warnings
Expand Down
7 changes: 5 additions & 2 deletions runners/test_runner.c
Expand Up @@ -1788,10 +1788,13 @@ const char *const builtin_powerlosses_help[] = {
"Run a custom leb16-encoded set of power-losses.",
};

// default to -Pnone,linear, which provides a good heuristic while still
// running quickly
const test_powerloss_t *test_powerlosses = (const test_powerloss_t[]){
{"none", run_powerloss_none, NULL, 0},
{"none", run_powerloss_none, NULL, 0},
{"linear", run_powerloss_linear, NULL, 0},
};
size_t test_powerloss_count = 1;
size_t test_powerloss_count = 2;

static void list_powerlosses(void) {
// at least size so that names fit
Expand Down

0 comments on commit cda2f6f

Please sign in to comment.