Use language server to replace its completion?

[Freed-Wu]

There is a language server for dot. Can we remove the completion function and let user to use language server, just keep compile function (LSP doesn't have this feature)?

• For developers, it can save maintain cost.
• For users, language server can provide better experience.

[Freed-Wu]

Hey, what is your opinion? If you agree, I think I can do it 😄 And if you are busy, you can add me to collaborator 👍

[liuchengxu]

Collaborator invite sent.

I don't think the existing completion function has to be removed, you can keep it as is and extend it with the language server support, for the language server is not always available.

[Freed-Wu]

Perhaps we can disable completion when executable('dot-language-server') == v:true because two same completions will give user confusion?

[liuchengxu]

By default only the omnifunc is defined, can you elaborate on how it interferes with the completion from the language server? I guess they can just co-exist as these two completions have different triggers.

graphviz.vim/ftplugin/dot.vim

Line 6 in dbe1de3

setlocal omnifunc=graphviz#completion#Omni

[Freed-Wu]

Oh, let me rethink if there are any method to combine LSP with this plugin.