Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please document the determinism of HashDiff.diff and friends #82

Open
kwasimensah opened this issue May 13, 2021 · 1 comment
Open

Please document the determinism of HashDiff.diff and friends #82

kwasimensah opened this issue May 13, 2021 · 1 comment

Comments

@kwasimensah
Copy link

kwasimensah commented May 13, 2021

So looking at compare_hashes.rb there's some sorting to make sure the results are stable and deterministic independent of the ordering of the keys. Is that true for all of the diff functions? If so it would be helpful to document this (either way) so that users of the library know if they need to sort results if they need stability (for unit tests, etc)

@liufengyun
Copy link
Owner

Sorry for the late response @kwasimensah . I just checked the history, it seems @krzysiek1507 made it deterministic in #52. Indeed, the docs needs to be updated about this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants