Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generating the list of tests from a PHPUnit XML file ignores the <groups> tag #142

Open
michelv opened this issue Nov 18, 2019 · 0 comments

Comments

@michelv
Copy link

michelv commented Nov 18, 2019

Hello,

It appears that the class CreateTestsQueueFromPhpUnitXML only handles the testsuite configuration.

This means that <groups> is ignored, and that for example some tests that you want to exclude by default aren't excluded.

The following pull request adds the handling of the @group annotation at the class level: #141

How it works: just like PHPUnit's TestRunner, it adds recursive filters to the testsuite iterator, and then we disregard a testsuite's file when its count of filtered tests is zero.

The drawback is that if the annotation @group is used only on some of the tests in a testsuite, the testsuite will still be executed entirely. Changing that behaviour implies the need for more extensive changes, and I don't know if those are relevant yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant