Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable -b before command #37

Open
liuggio opened this issue Sep 23, 2015 · 10 comments
Open

Re-enable -b before command #37

liuggio opened this issue Sep 23, 2015 · 10 comments
Labels

Comments

@liuggio
Copy link
Owner

liuggio commented Sep 23, 2015

Execute a process before consuming the queue, it executes this command once per process, useful for init schema and load fixtures.

@liuggio liuggio added the 2.0 label Sep 23, 2015
@tarlepp
Copy link
Contributor

tarlepp commented Sep 13, 2017

One way to handle this is to use phpunit.xml.dist file and define used bootstrap file there.

@DonCallisto
Copy link
Collaborator

@tarlepp do you think that this #102 could be tackled with phpunit.xml.dist?

@DonCallisto
Copy link
Collaborator

(or at least, if -b is already enabled in fastest, we can close this)

@tarlepp
Copy link
Contributor

tarlepp commented Sep 23, 2017

@DonCallisto currently fastest won't fail at all if phpunit.xml.dist bootstrap fails (eg. that has simple die(); on that script). And then fastest won't show any errors about any of those tests...

And this is quite annoying and really hard to actually figure out what is going on. Picture below to show this.
image

See that my bootstrap.php has die(); on line 24, and then if I run ./vendor/bin/fastest -x phpunit.xml.dist it doesn't fail at all. And actually any of those tests are really run.

@DonCallisto
Copy link
Collaborator

Ok, so those seems to be two different problems:

  • Run fastest with native -b option should stop if any errors happens in before command
  • Run fastest with phpunit.xml should stop if any errors happens if bootstrap fails or stops.

In both case, this issue seems to be the same of #102; isn't it?

@tarlepp
Copy link
Contributor

tarlepp commented Sep 23, 2017

@DonCallisto yeah the outcome is the same

@DonCallisto
Copy link
Collaborator

@tarlepp see #104. Please, leave any comment in that PR.
Moreover it solves only fastest -b "native" approach

@DonCallisto
Copy link
Collaborator

@tarlepp ping

@tarlepp
Copy link
Contributor

tarlepp commented Oct 11, 2017

@DonCallisto it's good

@DonCallisto
Copy link
Collaborator

Partially resolved in #104; still misses bootstrap.php fail handling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants