Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eval.py] Should the evaluation script clip to the original width and height? #37

Closed
aptlin opened this issue Jul 21, 2019 · 4 comments
Closed

Comments

@aptlin
Copy link

aptlin commented Jul 21, 2019

I was going over the evaluation script and noticed that in the end boxes are clipped to the resized image size, which seems strange. Shouldn't text boxes fit the original image size instead?

@liuheng92
Copy link
Owner

Because input image is resized, I dont think it is strange.

@aptlin
Copy link
Author

aptlin commented Jul 22, 2019

@liuheng92, I am not saying that the resize is strange, rather that the size to which we clip does not seem to make sense. Shouldn’t the boxes get clipped to the size of the original image instead, rather than the size of the resized image?

@liuheng92
Copy link
Owner

oh, I see. It is original image size which I had use. see this line

@aptlin
Copy link
Author

aptlin commented Jul 23, 2019

Thanks, sorry for the confusion, seems so stupid in retrospect. Closing the issue.

@aptlin aptlin closed this as completed Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants