Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store app password in stamp encrypted data #2549

Closed
jonatanklosko opened this issue Apr 5, 2024 · 4 comments · Fixed by #2550
Closed

Store app password in stamp encrypted data #2549

jonatanklosko opened this issue Apr 5, 2024 · 4 comments · Fixed by #2550
Assignees

Comments

@jonatanklosko
Copy link
Member

Currently we don't persist, but we can use the stamp.

@jonatanklosko jonatanklosko self-assigned this Apr 5, 2024
@hugobarauna
Copy link
Member

@jonatanklosko if we do that, I'd be able to configure the password for a Livebook app, and once I deploy that app, that password would be persisted there?

@jonatanklosko
Copy link
Member Author

jonatanklosko commented Apr 5, 2024

@hugobarauna for Teams, correct! And for personal hub, the machine you deploy to would need to have the same personal secret key.

@hugobarauna
Copy link
Member

@jonatanklosko that would be useful! It's better than the current alternative which is to have the same password for all deployed apps using the LIVEBOOK_APPS_PATH_PASSWORD env var.

@jonatanklosko
Copy link
Member Author

Yeah, the idea is that LIVEBOOK_APPS_PATH_PASSWORD could still be used when deploying with personal hub to HuggingFace, similarly to how we pass secrets using env vars (HF secrets). That's because with personal hub, stamping is inherently designed to work within the local user machine. However, with Teams agent deployment the current behaviour would be very confusing (and there's a clear way we can make it work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants