Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.1 compatibility #67

Merged
merged 3 commits into from
May 31, 2017
Merged

5.1 compatibility #67

merged 3 commits into from
May 31, 2017

Conversation

jmfederico
Copy link
Collaborator

Draftsman is not compatible with 5.1 series as it is, but small changes are needed that keep it backwards compatible.

I haven't changed draftsman.gemspec, but did test locally with 5.1.0.rc2 and all tests pass.

@jmfederico
Copy link
Collaborator Author

jmfederico commented Apr 21, 2017

Actually, it becomes incompatible with 4 and older versions of Activerecord.
Adding tests against multiple Activerecord versions

@jmfederico
Copy link
Collaborator Author

So, I am already getting my apps ready for Rails 5.1, and wanted to help with Draftsman.

There was only one deprecation that needed attention (parameters), and 1 change (belong_to).

I noticed that Travis tests were being run for different Ruby versions but not for different Activerecord versions.

I implemented separate Gemfiles for 5.0.x and 5.1.x versions.

I hope this is useful.

@chrisdpeters
Copy link
Collaborator

Thank you, @jmfederico. I'm currently busy on a tangent not related to this right now but will review soon and probably merge.

This also lights a fire under me to update my application to Rails 5. 🔥

@chrisdpeters chrisdpeters merged commit 87f2423 into copasetickid:master May 31, 2017
@chrisdpeters chrisdpeters added this to the 0.7 milestone May 31, 2017
chrisdpeters pushed a commit that referenced this pull request Jun 10, 2017
(Slight improvement to #67)
chrisdpeters added a commit that referenced this pull request Jun 12, 2017
@chrisdpeters
Copy link
Collaborator

@jmfederico Good news... I was able to restore ActiveRecord 4 compatibility. 🎉

@jmfederico
Copy link
Collaborator Author

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants