New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Draft] Full rewrite #2
Conversation
hey @mattdesl, this is really great, thanks for your help. :) code looks good to me. i gave you write access to this repo and the npm module, feel free to merge and publish when you feel it's complete. i think your ideas for the CLI/API are great, i had something similar in mind last night but just wanted to get a minimum transpiler using browserify transforms pushed so we could start iterating. |
regarding CLI/API: do we want to merge the |
I'm not sure if it's a good idea to merge package.json config, because:
However something similar might be worth considering to allow users to setup config without long shell commands. 馃槃 Pushed vinyl-fs which seem to handle a lot of the file streaming/copying for us. It is not part of the programmatic API but it seems like neither is Babel's multi-output option. |
@mattdesl haha, I was thinking of suggesting we write up something like this earlier today :P Thanks for the heads up! +1 on ignoring |
馃憤 also @hughsk gave you write access as well just in case. :) |
Ok, I am going to merge and continue iterating on master. |
I was looking into doing this today, and I started writing the exact same module (down to the same name, hehe) so I figure I'd just fork & submit a PR instead of fragmenting npm unnecessarily. 馃槃
Here is a draft, not complete. Some things:
filename
is now required as the input for the transpiler, since that's what browserify transforms expectopt.transform
now matches the way browserify resolves and handles transforms. Currently usesresolve.sync
since the async API would cause a lot more code complexity.--transform
in CLI-t
in CLIbasedir
can be specified from API/CLI to resolve differentlystandard
linting, npmignore, and some tweaks to readme.Something to still figure out is the general user-experience of the CLI/API, especially for whole directories (like babel does). I'm not sure whether
vinyl-fs
or something similar could help clean the code up.Directories:
Single-file:
/cc @hughsk since this tool could be useful for glslify modules 馃槃