Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon fixes #130

Merged
merged 3 commits into from
Dec 19, 2022
Merged

Icon fixes #130

merged 3 commits into from
Dec 19, 2022

Conversation

mdo
Copy link
Contributor

@mdo mdo commented Dec 14, 2022

  • Ensure icons are same canvas size to prevent misalignment and shifting
  • Use currentColor for fill to allow easy customization via color or fill style rules

- Ensure icons are same canvas size to prevent misalignment and shifting
- Use currentColor for fill to allow easy customization via color or fill style rules
@zeet-co
Copy link

zeet-co bot commented Dec 14, 2022

We're building your pull request over on Zeet.
Click me for more info about your build and deployment.
Once built, this branch can be tested at: https://components-storybook-ssgm-icon-im-d581ec.lapsoutha.production.livekit.app before merging 😉

@changeset-bot
Copy link

changeset-bot bot commented Dec 14, 2022

🦋 Changeset detected

Latest commit: 02c4d47

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@livekit/components-react Patch
@livekit/meet Patch
@livekit/component-example-next Patch
@livekit/component-docs-storybook Patch
@livekit/components-docs-gen Patch
@livekit/components-props-docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Dec 14, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
components-next ⬜️ Ignored (Inspect) Dec 19, 2022 at 9:01AM (UTC)
meet ⬜️ Ignored (Inspect) Dec 19, 2022 at 9:01AM (UTC)

@Ocupe
Copy link
Contributor

Ocupe commented Dec 15, 2022

@mdo good call with the svg icons 👍
The problem is that the icons you modifierd are all generated from the "original" icons in /packages/styles/icons. To avoid overwriting all your work the next time the icons are generated, you should instead modify the "originals" and generate the new version with yarn build.

@mdo
Copy link
Contributor Author

mdo commented Dec 15, 2022

@Ocupe Just took care of that, thanks!

@lukasIO lukasIO merged commit 9bbf4e3 into main Dec 19, 2022
@lukasIO lukasIO deleted the icon-improvements branch December 19, 2022 09:02
@github-actions github-actions bot mentioned this pull request Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants