-
Notifications
You must be signed in to change notification settings - Fork 731
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enabling camera after enabling screen sharing doesn't work on Firefox #1238
Comments
I discussed this issue in slack before & @boks1971 made one fix but it wasn't merge. This mainly happen if you try to share webcam quickly after share screen & simulcast is on. As a work around either disable simulcast or enable webcam first then enable screen share :-D |
@jibon57 Thanks for suggestion, but this work around won't work. We need both simulcast and flexibility to decide when to enable/disable screen sharing and camera. |
@boks1971 How's your fix? Do you have any branch that I could try out? |
@burzomir I made this Pion PR long long time ago - pion/webrtc#2107, but it did not make it into main line. At that time, I had an LiveKit server branch which @jibon57 tested out. But, I do not have that anymore. I am guessing the Pion PR may not apply now. It is quite old. |
@boks1971 @davidzhao I recently tried to deploy the main branch (65ad4b2) and the issue is still the same.
Also the problem is that when I try to publish the camera track again, even after unpublishing the screen share track, the camera no longer works, until I fully disconnect and go back into the room. Logs2023-03-25T12:37:28.732Z INFO livekit rtc/room.go:331 new participant joined {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "pID": "PA_oDwagMsnfUSD", "participant": "466", "protocol": 9, "options": {"AutoSubscribe":true}} 2023-03-25T12:37:28.733Z INFO livekit service/rtcservice.go:258 new client WS connected {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "connID": "CO_eGarTy4CZgSr"} 2023-03-25T12:37:28.733Z INFO livekit rtc/room.go:265 participant state changed {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "state": "JOINED", "participant": "466", "pID": "PA_oDwagMsnfUSD", "oldState": "JOINING"} 2023-03-25T12:37:29.843Z INFO livekit rtc/transport.go:597 selected ICE candidate pair {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "transport": "SUBSCRIBER", "pair": "(local) udp4 host 91.250.106.15:57670 <-> (remote) udp4 prflx 91.90.163.34:60401 related :0"} 2023-03-25T12:37:30.005Z INFO livekit rtc/room.go:265 participant state changed {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "state": "ACTIVE", "participant": "466", "pID": "PA_oDwagMsnfUSD", "oldState": "JOINED"} 2023-03-25T12:37:38.174Z INFO livekit rtc/signalhandler.go:44 client leaving room {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "464", "pID": "PA_TpDeTe4b2ffZ", "remote": false} 2023-03-25T12:37:38.174Z INFO livekit rtc/participant.go:628 participant closing {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "464", "pID": "PA_TpDeTe4b2ffZ", "remote": false, "sendLeave": true, "reason": "CLIENT_REQUEST_LEAVE"} 2023-03-25T12:37:38.174Z INFO livekit rtc/participant_signal.go:285 closing signal connection {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "464", "pID": "PA_TpDeTe4b2ffZ", "remote": false} 2023-03-25T12:37:38.176Z INFO livekit service/rtcservice.go:231 finishing WS connection {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "464", "pID": "PA_TpDeTe4b2ffZ", "remote": false, "connID": "CO_SxjB7m7GMeAN"} 2023-03-25T12:37:44.025Z INFO livekit rtc/room.go:331 new participant joined {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "pID": "PA_LgTwqN9vMn6C", "participant": "467", "protocol": 9, "options": {"AutoSubscribe":true}} 2023-03-25T12:37:44.026Z INFO livekit rtc/room.go:265 participant state changed {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "state": "JOINED", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "oldState": "JOINING"} 2023-03-25T12:37:44.026Z INFO livekit service/rtcservice.go:258 new client WS connected {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "connID": "CO_kvNnomch25TY"} 2023-03-25T12:37:45.160Z INFO livekit rtc/transport.go:597 selected ICE candidate pair {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "transport": "SUBSCRIBER", "pair": "(local) udp4 host 91.250.106.15:59216 <-> (remote) udp4 prflx 91.90.163.34:63928 related :0"} 2023-03-25T12:37:45.298Z INFO livekit rtc/participant.go:1486 pending track added {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "trackID": "TR_VCT4eVdDbuVwLY", "track": "sid:\"TR_VCT4eVdDbuVwLY\" type:VIDEO width:1280 height:720 source:CAMERA layers:{width:320 height:180 bitrate:120000} layers:{quality:MEDIUM width:640 height:360 bitrate:300000} layers:{quality:HIGH width:1280 height:720 bitrate:1700000}", "request": "cid:\"eaccfbcf-bf18-4232-8d01-2b972c26c547\" type:VIDEO width:1280 height:720 source:CAMERA layers:{width:320 height:180 bitrate:120000} layers:{quality:MEDIUM width:640 height:360 bitrate:300000} layers:{quality:HIGH width:1280 height:720 bitrate:1700000}"} 2023-03-25T12:37:45.376Z INFO livekit rtc/room.go:265 participant state changed {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "state": "ACTIVE", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "oldState": "JOINED"} 2023-03-25T12:37:45.527Z INFO livekit rtc/transport.go:597 selected ICE candidate pair {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "transport": "PUBLISHER", "pair": "(local) udp4 host 91.250.106.15:51554 <-> (remote) udp4 srflx 91.90.163.34:59411 related 192.168.50.44:59411"} 2023-03-25T12:37:45.641Z INFO livekit rtc/participant.go:1146 mediaTrack published {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "kind": "video", "trackID": "TR_VCT4eVdDbuVwLY", "rid": "q", "SSRC": 1597873360, "mime": "video/VP8"} 2023-03-25T12:37:45.642Z INFO livekit rtc/subscriptionmanager.go:133 subscribing to track {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "trackID": "TR_VCT4eVdDbuVwLY"} 2023-03-25T12:37:45.649Z INFO livekit rtc/participant.go:1146 mediaTrack published {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "kind": "video", "trackID": "TR_VCT4eVdDbuVwLY", "rid": "h", "SSRC": 1232099175, "mime": "video/VP8"} 2023-03-25T12:37:45.856Z INFO livekit rtc/subscribedtrack.go:180 updated subscribed track enabled {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "trackID": "TR_VCT4eVdDbuVwLY", "publisherID": "PA_LgTwqN9vMn6C", "publisher": "467", "enabled": false} 2023-03-25T12:37:45.865Z INFO livekit rtc/subscribedtrack.go:180 updated subscribed track enabled {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "trackID": "TR_VCT4eVdDbuVwLY", "publisherID": "PA_LgTwqN9vMn6C", "publisher": "467", "enabled": true} 2023-03-25T12:37:45.865Z INFO livekit rtc/dynacastmanager.go:227 committing quality change {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "trackID": "TR_VCT4eVdDbuVwLY", "relayed": false, "force": false, "committedMaxSubscribedQuality": {}, "maxSubscribedQuality": {"video/VP8":2}} 2023-03-25T12:37:45.865Z INFO livekit rtc/participant.go:1416 sending max subscribed quality {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "trackID": "TR_VCT4eVdDbuVwLY", "qualities": [{"codec":"vp8","qualities":[{"enabled":true},{"quality":1,"enabled":true},{"quality":2,"enabled":true}]}], "max": [{"CodecMime":"video/VP8","Quality":2}]} 2023-03-25T12:37:45.904Z INFO livekit sfu/forwarder.go:1526 upgrading layer {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "trackID": "TR_VCT4eVdDbuVwLY", "relayed": false, "current": "VideoLayer{s: -1, t: -1}", "target": "VideoLayer{s: 1, t: 3}", "max": "VideoLayer{s: 2, t: 3}", "layer": 1, "req": 1, "maxPublished": 1, "feed": 1232099175} 2023-03-25T12:37:45.911Z INFO livekit rtc/participant.go:1146 mediaTrack published {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "kind": "video", "trackID": "TR_VCT4eVdDbuVwLY", "rid": "f", "SSRC": 114951112, "mime": "video/VP8"} 2023-03-25T12:37:45.911Z INFO livekit sfu/forwarder.go:1526 upgrading layer {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "trackID": "TR_VCT4eVdDbuVwLY", "relayed": false, "current": "VideoLayer{s: 1, t: 3}", "target": "VideoLayer{s: 2, t: 3}", "max": "VideoLayer{s: 2, t: 3}", "layer": 2, "req": 2, "maxPublished": 2, "feed": 114951112} 2023-03-25T12:37:45.911Z INFO livekit sfu/forwarder.go:1568 reached max layer {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "trackID": "TR_VCT4eVdDbuVwLY", "relayed": false, "current": "VideoLayer{s: 2, t: 3}", "target": "VideoLayer{s: 2, t: 3}", "max": "VideoLayer{s: 2, t: 3}", "layer": 2, "req": 2, "maxPublished": 2, "feed": 114951112} 2023-03-25T12:38:18.834Z INFO livekit rtc/participant.go:1486 pending track added {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "trackID": "TR_VSFJjnmLZK9wWd", "track": "sid:\"TR_VSFJjnmLZK9wWd\" type:VIDEO width:1791 height:1163 source:SCREEN_SHARE layers:{quality:HIGH width:1791 height:1163 bitrate:300000}", "request": "cid:\"{4468b7ee-7f99-448c-bbcf-f7d428afbc91}\" type:VIDEO width:1791 height:1163 source:SCREEN_SHARE layers:{quality:HIGH width:1791 height:1163 bitrate:300000}"} 2023-03-25T12:38:19.072Z INFO livekit rtc/transport.go:597 selected ICE candidate pair {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "transport": "PUBLISHER", "pair": "(local) udp4 host 91.250.106.15:54347 <-> (remote) udp4 prflx 91.90.163.34:55636 related :0"} 2023-03-25T12:38:19.178Z INFO livekit rtc/participant.go:1146 mediaTrack published {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "kind": "video", "trackID": "TR_VSFJjnmLZK9wWd", "rid": "", "SSRC": 714812471, "mime": "video/VP8"} 2023-03-25T12:38:19.178Z INFO livekit rtc/subscriptionmanager.go:133 subscribing to track {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "trackID": "TR_VSFJjnmLZK9wWd"} 2023-03-25T12:38:19.396Z INFO livekit rtc/subscribedtrack.go:180 updated subscribed track enabled {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "trackID": "TR_VSFJjnmLZK9wWd", "publisherID": "PA_oDwagMsnfUSD", "publisher": "466", "enabled": false} 2023-03-25T12:38:19.400Z INFO livekit rtc/subscribedtrack.go:180 updated subscribed track enabled {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "trackID": "TR_VSFJjnmLZK9wWd", "publisherID": "PA_oDwagMsnfUSD", "publisher": "466", "enabled": true} 2023-03-25T12:38:19.400Z INFO livekit rtc/dynacastmanager.go:227 committing quality change {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "trackID": "TR_VSFJjnmLZK9wWd", "relayed": false, "force": false, "committedMaxSubscribedQuality": {}, "maxSubscribedQuality": {"video/VP8":2}} 2023-03-25T12:38:19.400Z INFO livekit rtc/participant.go:1416 sending max subscribed quality {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "trackID": "TR_VSFJjnmLZK9wWd", "qualities": [{"codec":"vp8","qualities":[{"enabled":true},{"quality":1,"enabled":true},{"quality":2,"enabled":true}]}], "max": [{"CodecMime":"video/VP8","Quality":2}]} 2023-03-25T12:38:20.206Z INFO livekit sfu/forwarder.go:1526 upgrading layer {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "trackID": "TR_VSFJjnmLZK9wWd", "relayed": false, "current": "VideoLayer{s: -1, t: -1}", "target": "VideoLayer{s: 0, t: 3}", "max": "VideoLayer{s: 0, t: 3}", "layer": 0, "req": 0, "maxPublished": 0, "feed": 714812471} 2023-03-25T12:38:20.206Z INFO livekit sfu/forwarder.go:1568 reached max layer {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "trackID": "TR_VSFJjnmLZK9wWd", "relayed": false, "current": "VideoLayer{s: 0, t: -1}", "target": "VideoLayer{s: 0, t: 3}", "max": "VideoLayer{s: 0, t: 3}", "layer": 0, "req": 0, "maxPublished": 0, "feed": 714812471} 2023-03-25T12:38:29.006Z INFO livekit rtc/participant.go:1486 pending track added {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "trackID": "TR_VCCwxDyo9hpdBb", "track": "sid:\"TR_VCCwxDyo9hpdBb\" type:VIDEO width:1280 height:720 source:CAMERA layers:{width:320 height:180 bitrate:120000} layers:{quality:MEDIUM width:640 height:360 bitrate:300000} layers:{quality:HIGH width:1280 height:720 bitrate:1700000}", "request": "cid:\"{945b4841-9b8c-4d09-947d-7cf0adc92a5e}\" type:VIDEO width:1280 height:720 source:CAMERA layers:{width:320 height:180 bitrate:120000} layers:{quality:MEDIUM width:640 height:360 bitrate:300000} layers:{quality:HIGH width:1280 height:720 bitrate:1700000}"} 2023-03-25T12:38:29.214Z ERROR livekit.pc logger/logadapter.go:108 Incoming unhandled RTP ssrc(2682674836), OnTrack will not be fired. stream id RTP Extensions required for Simulcast {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "transport": "PUBLISHER"} github.com/livekit/livekit-server/pkg/logger.(*logAdapter).Errorf /workspace/pkg/logger/logadapter.go:108 github.com/pion/webrtc/v3.(*PeerConnection).undeclaredRTPMediaProcessor.func1 /go/pkg/mod/github.com/pion/webrtc/v3@v3.1.58/peerconnection.go:1660 2023-03-25T12:38:29.215Z ERROR livekit.pc logger/logadapter.go:108 Incoming unhandled RTP ssrc(793246391), OnTrack will not be fired. stream id RTP Extensions required for Simulcast {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "transport": "PUBLISHER"} github.com/livekit/livekit-server/pkg/logger.(*logAdapter).Errorf /workspace/pkg/logger/logadapter.go:108 github.com/pion/webrtc/v3.(*PeerConnection).undeclaredRTPMediaProcessor.func1 /go/pkg/mod/github.com/pion/webrtc/v3@v3.1.58/peerconnection.go:1660 2023-03-25T12:38:59.732Z ERROR livekit supervisor/participant_supervisor.go:142 supervisor error on publication {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "trackID": "TR_VCCwxDyo9hpdBb", "error": "publish time out"} github.com/livekit/livekit-server/pkg/rtc/supervisor.(*ParticipantSupervisor).checkPublications /workspace/pkg/rtc/supervisor/participant_supervisor.go:142 github.com/livekit/livekit-server/pkg/rtc/supervisor.(*ParticipantSupervisor).checkState /workspace/pkg/rtc/supervisor/participant_supervisor.go:131 2023-03-25T12:39:20.597Z INFO livekit rtc/subscribedtrack.go:180 updated subscribed track enabled {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "trackID": "TR_VSFJjnmLZK9wWd", "publisherID": "PA_oDwagMsnfUSD", "publisher": "466", "enabled": false} 2023-03-25T12:39:25.697Z INFO livekit rtc/dynacastmanager.go:227 committing quality change {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "trackID": "TR_VSFJjnmLZK9wWd", "relayed": false, "force": true, "committedMaxSubscribedQuality": {"video/VP8":2}, "maxSubscribedQuality": {"video/VP8":3}} 2023-03-25T12:39:25.698Z INFO livekit rtc/participant.go:1416 sending max subscribed quality {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "trackID": "TR_VSFJjnmLZK9wWd", "qualities": [{"codec":"vp8","qualities":[{},{"quality":1},{"quality":2}]}], "max": [{"CodecMime":"video/VP8","Quality":3}]} 2023-03-25T12:39:26.649Z ERROR livekit.pc logger/logadapter.go:108 Incoming unhandled RTP ssrc(345282385), OnTrack will not be fired. stream id RTP Extensions required for Simulcast {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "transport": "PUBLISHER"} github.com/livekit/livekit-server/pkg/logger.(*logAdapter).Errorf /workspace/pkg/logger/logadapter.go:108 github.com/pion/webrtc/v3.(*PeerConnection).undeclaredRTPMediaProcessor.func1 /go/pkg/mod/github.com/pion/webrtc/v3@v3.1.58/peerconnection.go:1660 2023-03-25T12:39:28.995Z INFO livekit rtc/subscribedtrack.go:180 updated subscribed track enabled {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "466", "pID": "PA_oDwagMsnfUSD", "remote": false, "trackID": "TR_VCT4eVdDbuVwLY", "publisherID": "PA_LgTwqN9vMn6C", "publisher": "467", "enabled": false} 2023-03-25T12:39:34.097Z INFO livekit rtc/dynacastmanager.go:227 committing quality change {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "trackID": "TR_VCT4eVdDbuVwLY", "relayed": false, "force": true, "committedMaxSubscribedQuality": {"video/VP8":2}, "maxSubscribedQuality": {"video/VP8":3}} 2023-03-25T12:39:34.097Z INFO livekit rtc/participant.go:1416 sending max subscribed quality {"room": "521501298", "roomID": "RM_mftVSjXFDTjA", "participant": "467", "pID": "PA_LgTwqN9vMn6C", "remote": false, "trackID": "TR_VCT4eVdDbuVwLY", "qualities": [{"codec":"vp8","qualities":[{},{"quality":1},{"quality":2}]}], "max": [{"CodecMime":"video/VP8","Quality":3}]} |
I tried to set So far the only good workaround I found is to:
|
Additional details in Slack thread: https://livekit-users.slack.com/archives/C01KVTJH6BX/p1680599433828099?thread_ts=1676902391.766349&cid=C01KVTJH6BX |
@cnderrauber Could this one be fixed by #1621 too? |
Doubt it. That is a different issue as far as I remember. |
This should be fixed upstream by pion/webrtc#2444 |
Describe the bug
Enabling camera after enabling screen sharing doesn't work on Firefox (107.0.1 (64-bit) and 108.0.1 (64-bit)). Reproducible in LiveKit's playground https://livekit.io/playground#code=60c0983cd7e07fd1179620ce
Expected behavior
Both camera and screen sharing are visible
Additional context
I was able to capture some logs from livekit-server. There are some error rows.
The text was updated successfully, but these errors were encountered: