Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-generate TicketBroker binding to include named structs #1147

Closed
yondonfu opened this issue Oct 31, 2019 · 0 comments · Fixed by #2013
Closed

Re-generate TicketBroker binding to include named structs #1147

yondonfu opened this issue Oct 31, 2019 · 0 comments · Fixed by #2013

Comments

@yondonfu
Copy link
Member

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

At the moment, the TicketBroker contract binding does not support named structs because the version of abigen used to generate the binding did not support using internalType information from a contract's ABI and as a result could not use the name of a Solidity struct as the name for the corresponding Go struct.

An abigen PR was just merged that adds support for using the internalType information from a contract's ABI to generate a binding that includes named structs.

Describe the solution you'd like
A clear and concise description of what you want to happen.

Re-generate the TicketBroker binding in eth/contracts/ticketBroker.go using the latest version of abigen. This should also allow us to remove the custom code in client.GetSenderInfo() - instead, we can directly call TicketBrokerSession.GetSenderInfo().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant