Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pm: Increase TicketParams expiration #1872

Closed
kyriediculous opened this issue May 5, 2021 · 0 comments · Fixed by #1873
Closed

pm: Increase TicketParams expiration #1872

kyriediculous opened this issue May 5, 2021 · 0 comments · Fixed by #1873
Assignees

Comments

@kyriediculous
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently the TicketParams expiration is set to 5 blocks which forces relatively strict sync between Orchestrators and Broadcasters in terms of their view of the canonical Ethereum chain.

var paramsExpirationBlock = big.NewInt(5)

It's also possible for the TicketParams to expire when a segment is in flight, while this is an edge case because input segments are capped in size it is still possible to occur, especially since Ethereum blocktime is not fixed.

The propasal is to double this duration to 10 blocks , which would be 2 minutes on average. This seems to be a reasonable balance between sync requirements between nodes and staleness of values such as ticket faceValue, which depends on the gas price.

Additional context
We also want to refresh ticket params before they expire at e.g. 10% before that in #1852. At the current expiration this would involve frequent refreshes, at 10 blocks this seems more reasonable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant