Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reuse of transcoding job does only work on rinkeby but wont be used on mainnet #554

Closed
f1l1b0x opened this issue Sep 5, 2018 · 2 comments

Comments

@f1l1b0x
Copy link

f1l1b0x commented Sep 5, 2018

restarting a rtmp source stream to LPMS will result in a new job with a new on chain job message instead of reusing it.

behavior on rinkeby is different than on mainnet!

on rinkeby it works as expected and reuses the jobid and transcoder
on mainnet it starts a new one

to test start a new job on rinkeby and start / stop / start OBS
you will only see 1 on chain tx no matter how often you start which is as it should be

now test on mainnet and do the start / stop / start OBS
you will notice a new tx per start in OBS

@j0sh
Copy link
Contributor

j0sh commented Sep 5, 2018

We looked at this earlier yesterday. In this particular case, there was no job in the local DB that matched the node's current transcode options, which led to new job(s) being created. The node never received the JobCreated events from the blockchain, so it didn't have an opportunity to record the information in the DB. Those missing events are a wider issue that should be remedied by #492 .

In general, I think this illustrates a few good reasons for having a separate job creation step (#429) since we could improve the UX around the job-creation transaction, and help the user avoid submitting unnecessary transactions (especially without their knowledge).

@j0sh
Copy link
Contributor

j0sh commented Dec 10, 2018

Most of these issues aren't applicable with Streamflow, so closing this ticket.

@j0sh j0sh closed this as completed Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants