Lit enablement #272
Merged
Lit enablement #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
victorges
approved these changes
Feb 14, 2023
| playsInline | ||
| muted={muted} | ||
| crossOrigin={ | ||
| allowCrossOriginCredentials ? 'use-credentials' : 'anonymous' |
There was a problem hiding this comment.
Is anonymous the default? Either way, what happens if we set it as undefined instead to leave it for the browser to decide the default?
Comment on lines
+123
to
+125
| xhrSetup(xhr, _url) { | ||
| xhr.withCredentials = Boolean(allowCrossOriginCredentials); | ||
| }, |
There was a problem hiding this comment.
WDYT of only setting this if the prop is set?
Suggested change
| xhrSetup(xhr, _url) { | |
| xhr.withCredentials = Boolean(allowCrossOriginCredentials); | |
| }, | |
| xhrSetup: !allowCrossOriginCredentials : undefined : (xhr, _url) => { | |
| xhr.withCredentials = true | |
| }, |
| @@ -154,6 +160,9 @@ export const VideoPlayer = React.forwardRef<HTMLVideoElement, VideoPlayerProps>( | |||
| muted={muted} | |||
| poster={typeof poster === 'string' ? poster : undefined} | |||
| preload={priority ? 'auto' : 'metadata'} | |||
| crossOrigin={ | |||
| allowCrossOriginCredentials ? 'use-credentials' : 'anonymous' | |||
There was a problem hiding this comment.
Same (low pri) comment about the default
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added features for WIP Lit protocol integration.