Skip to content

Commit

Permalink
fix fixture URLs
Browse files Browse the repository at this point in the history
  • Loading branch information
geuben committed Mar 20, 2020
1 parent 4f4bf2b commit be12f98
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 4 deletions.
8 changes: 7 additions & 1 deletion livestyled/models/fixture.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,13 @@ def __init__(
self._competition = Competition.placeholder(id=competition_id)
self._venue = SportVenue.placeholder(id=venue_id)
self._status = status
self.url = url
if url:
if isinstance(url, Url):
self.url = url
elif isinstance(url, dict):
self.url = Url(**url)
else:
self.url = None
self.allow_overwrite = allow_overwrite

@classmethod
Expand Down
19 changes: 16 additions & 3 deletions livestyled/models/tests/test_fixture.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
from datetime import datetime, timedelta, timezone

from livestyled.models.fixture import Fixture
from livestyled.models.fixture import Fixture, Url
from livestyled.schemas.fixture import FixtureSchema


Expand All @@ -19,7 +19,11 @@ def test_create_fixture_from_deserialized():
'venue_id': 5,
'external_id': None,
'status': 'Active',
'url': 'https://test.com'
'url': {
'url': 'https://test.com',
'is_enabled': True,
'title': 'TEST'
}
}
fixture = Fixture(**deserialized_fixture)
assert fixture
Expand All @@ -40,9 +44,18 @@ def test_serialize_fixture():
'venue_id': 5,
'external_id': None,
'status': 'Active',
'url': 'https://test.com'
'url': {
'url': 'https://test.com',
'is_enabled': True,
'title': 'TEST'
}
}
fixture = Fixture(**deserialized_fixture)
serialized_fixture = FixtureSchema().dump(fixture)
assert serialized_fixture
assert serialized_fixture['competition'] == '/v4/competitions/6'
assert serialized_fixture['url'] == {
'url': 'https://test.com',
'is_enabled': True,
'title': 'TEST'
}

0 comments on commit be12f98

Please sign in to comment.