Merge pull request #74 from realifetech/feature/CTD-1855-tdc---be-map…

…-ticket-data-to-rlt CTD-1855 fix UserAlias error
realifetech · Apr 25, 2022 · e89f1e5 · e89f1e5
2 parents fbdae69 + 5583c69
commit e89f1e5
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 10 deletions.
diff --git a/livestyled/models/user.py b/livestyled/models/user.py
@@ -292,27 +292,25 @@ def placeholder(
 class UserAlias:
     def __init__(
             self,
+            id: int,
             user_alias_type,
-            user,
             value,
-            updated_at: datetime,
-            created_at: datetime
+            updated_at: datetime or None = None,
+            created_at: datetime or None = None
     ):
+        self.id = id
         self.user_alias_type = User.placeholder(int(user_alias_type))
-        self.user = User.placeholder(int(user))
         self.value = value
         self.created_at = created_at
         self.updated_at = updated_at
 
     @classmethod
     def create_new(
             cls,
-            user,
             user_alias_type,
             value
     ):
         user_alias = UserAlias(
-            user=user,
             user_alias_type=user_alias_type,
             value=value,
             updated_at=None,

diff --git a/livestyled/schemas/tests/fixtures/example_user.json b/livestyled/schemas/tests/fixtures/example_user.json
@@ -68,5 +68,14 @@
             "updatedAt": "2020-02-19T18:28:27+00:00"
         }
     ],
-    "cohorts": []
-}
+    "cohorts": [],
+    "userAliases": [
+        {
+            "@id": "/user_management/user_aliases/510",
+            "@type": "UserAlias",
+            "id": 510,
+            "userAliasType": "/user_management/user_alias_types/4",
+            "value": "test1234"
+        }
+    ]
+}
diff --git a/livestyled/schemas/tests/test_users.py b/livestyled/schemas/tests/test_users.py
@@ -73,7 +73,15 @@ def test_deserialize_user():
                     'wifi_connected': True
                 }
             ],
-            'user_aliases': []
+            'user_aliases': [
+                {
+                    'id': 510,
+                    'user_alias_type': 4,
+                    'value': 'test1234',
+                    'created_at': None,
+                    'updated_at': None
+                }
+            ]
         }
 
 

diff --git a/livestyled/tests/fixtures/mock_responses/ls_api/user_1234.json b/livestyled/tests/fixtures/mock_responses/ls_api/user_1234.json
@@ -50,5 +50,14 @@
         "/v4/cohorts/1",
         "/v4/cohorts/2",
         "/v4/cohorts/8"
+    ],
+    "userAliases": [
+        {
+            "@id": "/user_management/user_aliases/510",
+            "@type": "UserAlias",
+            "id": 510,
+            "userAliasType": "/user_management/user_alias_types/4",
+            "value": "test1234"
+        }
     ]
-}
+}