d actual edits to first para #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've restored the order to 'maps' -> 'images' so we get a clearer narative as in the current existing repo; and shortened / combined a sentence, as it was repeating 'non-maps' and 'maps', so I used 'any images' instead to make it more intuitive to read. I was also going to add a few sentences giving the nice positive spin about interdisciplinary cross-pollination of image analysis, but not sure where this should go: I don't want to break the flow to the instructions, so perhaps it can go after the bullet points?
|
@dcsw2 Thanks, re:
Sounds good. |
kasra-hosseini
approved these changes
Apr 25, 2022
|
Ok |
dcsw2
commented
Apr 26, 2022
| @@ -3,7 +3,7 @@ | |||
| <p align="center"> | |||
| <h1>MapReader</h1> | |||
| </p> | |||
| <h2>A computer vision pipeline for analyzing and exploring images and maps at scale</h2> | |||
| <h2>A computer vision pipeline for analyzing and exploring maps and images at scale</h2> | |||
There was a problem hiding this comment.
Hi @kasra-hosseini this change doesn't seem to have gone through yet, but the two below on lines 33/35 have
There was a problem hiding this comment.
Hi @dcsw2 It did, but today, I changed it to: A computer vision pipeline for exploring and analyzing images at scale to emphasise its generalizability. However, to emphasize maps and images as two input types, the first line reads:
MapReader is an end-to-end computer vision (CV) pipeline for analyzing and exploring large collections of maps and images.
Does it make sense?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've restored the order to 'maps' -> 'images' so we get a clearer narative as in the current existing repo; and shortened / combined a sentence, as it was repeating 'non-maps' and 'maps', so I used 'any images' instead to make it more intuitive to read.
I was also going to add a few sentences giving the nice positive spin about interdisciplinary cross-pollination of image analysis, but not sure where this should go: I don't want to break the flow to the instructions, so perhaps it can go after the bullet points?