Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a potential bug on damage detection / frame #43

Closed
livramatheus opened this issue Jun 18, 2022 · 1 comment
Closed

Fix a potential bug on damage detection / frame #43

livramatheus opened this issue Jun 18, 2022 · 1 comment
Assignees
@livramatheus
Labels
bug Something isn't working
Milestone
0 - Overall

Comments

@livramatheus
Copy link
Owner

On attack function, under Fighter.js, there is a potential bug on this.curFrame === Attack.frameDmg instances.
(I think that is always detecting damage on frame 0).
@livramatheus livramatheus added the bug Something isn't working label Jun 18, 2022
@livramatheus livramatheus added this to the 0 - Game Quality milestone Jun 18, 2022
@livramatheus livramatheus self-assigned this Jun 18, 2022
@livramatheus
Copy link
Owner Author

Fixed on 1981ecb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@livramatheus livramatheus

Labels
bug Something isn't working
Projects
None yet
Milestone
0 - Overall
Development

No branches or pull requests
1 participant
@livramatheus