Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flask >= 3, from flask import Markup broken #108

Closed
ghmj2417 opened this issue Oct 1, 2023 · 4 comments
Closed

flask >= 3, from flask import Markup broken #108

ghmj2417 opened this issue Oct 1, 2023 · 4 comments

Comments

@ghmj2417
Copy link

ghmj2417 commented Oct 1, 2023

Per flask pull request, pallets/flask#5223, Markup needs to be imported from markupsafe. flask-paginate is currently broken when using flask >= 3 because it is still trying to pull Markup from flask. https://github.com/lixxu/flask-paginate/blob/master/flask_paginate/__init__.py#L18
@NiTRoeSE
Copy link

NiTRoeSE commented Oct 2, 2023

Same problem here.. pls fix this.
Thanks in advanced!

@tomrtk tomrtk mentioned this issue Oct 2, 2023
Merged
@lixxu
Copy link
Owner

lixxu commented Oct 8, 2023

fixed. please try new release.

@ghmj2417
Copy link
Author

I am testing it today. I will follow up when I am done.

@NiTRoeSE
Copy link

fixed. please try new release.

Thanks, it works for me. :)

@lixxu lixxu closed this as completed Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lixxu @ghmj2417 @NiTRoeSE