Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quote url value of href attribute for bulma css #112

Closed
D1CED opened this issue Apr 10, 2024 · 2 comments
Closed

quote url value of href attribute for bulma css #112

D1CED opened this issue Apr 10, 2024 · 2 comments

Comments

@D1CED
Copy link

D1CED commented Apr 10, 2024

The only case where the argument 0 is not quoted is in bulma (line three from below).

# previous link
_bs = '<li class="previous"><a href="{0}"{2}>{1}</a></li>'
_bs33 = '<li><a href="{0}" aria-label="Previous"{2}>\
<span aria-hidden="true">{1}</span></a></li>'
_bs4 = '<li class="page-item">\
<a class="page-link" href="{0}" aria-label="Previous"{2}>\
<span aria-hidden="true">{1}</span>\
<span class="sr-only">Previous</span></a></li>'
_bs5 = '<li class="page-item">\
<a class="page-link" href="{0}" aria-label="Previous"{2}>\
<span aria-hidden="true">{1}</span></a></li>'
_bulma = '<a class="pagination-previous" href={0} aria-label="Previous"{2}>{1}</a>'
_materialize = '<li class="waves-effect"><a href="{0}"{1}>\
<i class="material-icons">chevron_left</i></a></li>'

Is this intentional? I don't think leaving the value unquoted is wise here.

The effected lines are 36, 64 and 109 where url values are not quoted and they only appear in the context of bulma.

Cheers jmh.

@lixxu
Copy link
Owner

lixxu commented Apr 12, 2024

yes, it's a bug. New version fixed.

@D1CED
Copy link
Author

D1CED commented Apr 12, 2024

Thanks for the quick fix.

@D1CED D1CED closed this as completed Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants